-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic anyhow integration #165
Conversation
Any feedback on the change? Something you would be able to integrate? |
I understand that sentry has recently changed in open source, is sentry no longer accepting community contributions? |
@quininer only the licensing for the server components changed: https://twitter.com/mitsuhiko/status/1192188542988038146. and sentry-rust is a client-side only library |
@repi could you please update the branch with the base branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. And I have been successfully using this.
However, my Rust knowledge is not good enough to review the code.
Also, it would be great to have some tests here. Would you mind taking a look at this?
The maintainers of this repo have not given any feedback about this in 3 months, I will not do any further work on this. We have our own fork of sentry-rust that we use for now with this and additional changes. |
As of a few hours ago |
I’m making good progress with the internals, and will try to get to all the open PRs in the next few weeks :-) |
closing, as this was added in #212 |
This adds an optional integration for the
anyhow
error crate that can be enabled with thewith_anyhow
feature.It works very similar to the
failure
crate but does not here support backtraces, asanyhow
only supports backtraces on nightly. One could implement support for nightly-only backtraces but we don't have a need for that so didn't do it in this PR.Fix #162