Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Native SDK to v0.5.3 #173

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 8, 2022

Bumps modules/sentry-native from 0.5.2 to 0.5.3.

Auto-generated by a dependency updater.

Changelog

0.5.3

Fixes:

  • Linux module-finder now also searches for code-id in ".note" ELF sections (#775)

Internal:

  • CI: updated github actions to upgrade deprecated node runners. (#767)
  • CI: upgraded Ubuntu to 20.04 for "old gcc" (v7) job due to deprecation. (#768)

@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-native/0.5.3 branch 2 times, most recently from 5cfd8e5 to 0852670 Compare December 9, 2022 06:33
@tustanivsky
Copy link
Collaborator

@vaind have you seen similar issues after updating to the latest sentry-native with other SDKs? I've noticed that some folks faced this problem because of the ubuntu version, though apparently it's not the case here

@vaind
Copy link
Collaborator

vaind commented Dec 12, 2022

@vaind have you seen similar issues after updating to the latest sentry-native with other SDKs? I've noticed that some folks faced this problem because of the ubuntu version, though apparently it's not the case here

No, it's not an issue elsewhere AFAIK.

I think the issue is caused by the discrepancy between the compiler version used to build the libsentry.so & the one available in the Unreal docker image. Some of the new code added to this version depends GLIBC_2.33 library code from which is missing on the old image Unreal is based on. We may need to change the CI to build libsentry.so (the sentry-native dependency) in this repo's CI to use a matching compiler version or build it directly in the Unreal docker image using the compiler that's available there. At the moment the build is running on ubuntu-latest (currently 20.04) which yields the following GLIBC symbol dependencies for libsentry.so (objdump -T libsentry.so | grep GLIBC_ | sed 's/.*GLIBC_\([.0-9]*\).*/\1/g' | sort -Vur)

Sentry-native v0.5.2

2.17
2.15
2.14
2.12
2.7
2.4
2.3.4
2.3.2
2.3
2.2.5

Sentry-native v0.5.3

2.34
2.33
2.17
2.15
2.14
2.7
2.4
2.3.4
2.3.2
2.3
2.2.5

@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-native/0.5.3 branch 3 times, most recently from 32119c9 to 7d53c0f Compare December 19, 2022 06:46
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-native/0.5.3 branch 5 times, most recently from ef6fd9f to b1fd661 Compare December 28, 2022 06:57
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-native/0.5.3 branch 2 times, most recently from 9aa2367 to 6d956ff Compare January 2, 2023 07:07
@bruno-garcia bruno-garcia force-pushed the deps/modules/sentry-native/0.5.3 branch from 6d956ff to 41eee68 Compare January 3, 2023 07:04
Copy link
Collaborator

@tustanivsky tustanivsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks @vaind

@vaind vaind merged commit e5e3ae1 into main Jan 11, 2023
@vaind vaind deleted the deps/modules/sentry-native/0.5.3 branch January 11, 2023 17:38
@tustanivsky tustanivsky mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants