Add flag indicating which package version is used (GitHub or Marketplace) #479
Conversation
|
| { | ||
| if(!FPaths::FileExists(GetHandlerPath())) | ||
| { | ||
| UE_LOG(LogSentrySdk, Log, TEXT("Crashpad executable couldn't be found so Breakpad will be used instead. " |
There was a problem hiding this comment.
I don't get how we fall back to Breakpad. Is that an implicit fallback during initialization due to a missing Crashpad executable? Because the non-existing path still gets set.
There was a problem hiding this comment.
We determine which backend sentry-native should be using by checking whether the crashpad_handler executable exists within the package during the plugin's build. If at some point user decides to switch to Breakpad simply deleting the crashpad_handler executable won't be enough and plugin rebuild will be required. In this case handler path will be ignored during the initialization and won't affect its result.
| FPlatformMisc::SetCrashHandlingType(settings->EnableAutoCrashCapturing | ||
| ? ECrashHandlingType::Disabled | ||
| : ECrashHandlingType::Default); |
There was a problem hiding this comment.
This is a fallback to still keep the built-in crash reporter functional?
There was a problem hiding this comment.
Yes, without it we won't be able to restore normal crash reporter behavior within the same editor session even after disabling EnableAutoCrashCapturing in plugin's settings.
plugin-dev/Source/Sentry/Private/Desktop/SentrySubsystemDesktop.cpp
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This PR introduces the following changes:
IsMarketplaceflag value is set in CI during the plugin packagingIsMarketplaceflag added to the default event's contextsentry-nativeinitialization logic