Add API allowing to check if captured event is ANR error #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bitsandfoxes
approved these changes
Jun 27, 2024
| @@ -54,3 +54,8 @@ bool SentryEventAndroid::IsCrash() const | |||
| { | |||
| return CallMethod<bool>(IsCrashMethod); | |||
| } | |||
|
|
|||
| bool SentryEventAndroid::IsAppNotResponding() const | |||
There was a problem hiding this comment.
Suggested change
| bool SentryEventAndroid::IsAppNotResponding() const | |
| bool SentryEventAndroid::IsAnr() const |
We're using the abbrevation everywhere else.
| @@ -19,6 +19,7 @@ class SentryEventAndroid : public ISentryEvent, public FSentryJavaObjectWrapper | |||
| virtual void SetLevel(ESentryLevel level) override; | |||
| virtual ESentryLevel GetLevel() const override; | |||
| virtual bool IsCrash() const override; | |||
| virtual bool IsAppNotResponding() const override; | |||
There was a problem hiding this comment.
Suggested change
| virtual bool IsAppNotResponding() const override; | |
| virtual bool IsAnr() const override; |
| @@ -54,3 +54,21 @@ bool SentryEventApple::IsCrash() const | |||
| { | |||
| return EventApple.error != nullptr; | |||
| } | |||
|
|
|||
| bool SentryEventApple::IsAppNotResponding() const | |||
There was a problem hiding this comment.
Suggested change
| bool SentryEventApple::IsAppNotResponding() const | |
| bool SentryEventApple::IsAnr() const |
| @@ -20,6 +20,7 @@ class SentryEventApple : public ISentryEvent | |||
| virtual void SetLevel(ESentryLevel level) override; | |||
| virtual ESentryLevel GetLevel() const override; | |||
| virtual bool IsCrash() const override; | |||
| virtual bool IsAppNotResponding() const override; | |||
There was a problem hiding this comment.
Suggested change
| virtual bool IsAppNotResponding() const override; | |
| virtual bool IsAnr() const override; |
| @@ -60,4 +60,10 @@ bool SentryEventDesktop::IsCrash() const | |||
| return IsCrashEvent; | |||
| } | |||
|
|
|||
| bool SentryEventDesktop::IsAppNotResponding() const | |||
There was a problem hiding this comment.
Suggested change
| bool SentryEventDesktop::IsAppNotResponding() const | |
| bool SentryEventDesktop::IsAnr() const |
| @@ -16,4 +16,5 @@ class ISentryEvent | |||
| virtual void SetLevel(ESentryLevel level) = 0; | |||
| virtual ESentryLevel GetLevel() const = 0; | |||
| virtual bool IsCrash() const = 0; | |||
| virtual bool IsAppNotResponding() const = 0; | |||
There was a problem hiding this comment.
Suggested change
| virtual bool IsAppNotResponding() const = 0; | |
| virtual bool IsAnr() const = 0; |
| @@ -80,6 +80,14 @@ bool USentryEvent::IsCrash() const | |||
| return EventNativeImpl->IsCrash(); | |||
| } | |||
|
|
|||
| bool USentryEvent::IsAppNotResponding() const | |||
There was a problem hiding this comment.
Suggested change
| bool USentryEvent::IsAppNotResponding() const | |
| bool USentryEvent::IsAnr() const |
| if(!EventNativeImpl) | ||
| return false; | ||
|
|
||
| return EventNativeImpl->IsAppNotResponding(); |
There was a problem hiding this comment.
Suggested change
| return EventNativeImpl->IsAppNotResponding(); | |
| return EventNativeImpl->IsAnr(); |
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Features | |||
|
|
|||
| - Add API allowing to check if captured event is ANR error ([#581](https://github.com/getsentry/sentry-unreal/pull/581)) | |||
There was a problem hiding this comment.
Suggested change
| - Add API allowing to check if captured event is ANR error ([#581](https://github.com/getsentry/sentry-unreal/pull/581)) | |
| - Added `IsAnr()` method to mobile `SentryEvents` to check if the event is caused by the Application Not Responding ([#581](https://github.com/getsentry/sentry-unreal/pull/581)) |
| @@ -48,6 +48,10 @@ class SENTRY_API USentryEvent : public UObject | |||
| UFUNCTION(BlueprintPure, Category = "Sentry") | |||
| bool IsCrash() const; | |||
|
|
|||
| /** Gets flag indicating whether the event is an Application Not Responding (ANR) error. */ | |||
| UFUNCTION(BlueprintPure, Category = "Sentry") | |||
| bool IsAppNotResponding() const; | |||
There was a problem hiding this comment.
It looks like it's nice having it written out in the blueprints?
There was a problem hiding this comment.
We can add a meta=(DisplayName="Is App Not Responding") attribute for UFUNCTION here in order to display the full name in blueprints while still having IsAnr in C++ as everywhere else. Does that sound good?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to
USentryEventwhich allows checking if the captured event is an ANR error. By default, ANR error tracking is turned off in plugin settings.Note, that ANR error tracking works only on Android/Apple since
sentry-nativedoesn't support it at the moment.Closes #574