Add opt-in screenshot attachment for crash events captured on Windows/Linux #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugin-dev/Source/Sentry/Private/Desktop/SentrySubsystemDesktop.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Changes like this reeeally make me think we should put a linter in the repo.
There was a problem hiding this comment.
We'll probably cover this in scope of #575
Co-authored-by: Stefan Jandl <reg@bitfox.at>
# Conflicts: # CHANGELOG.md
bitsandfoxes
approved these changes
Jun 28, 2024
If a screenshot can't be captured for some reason crashpad will simply ignore that and capture crash as usual without adding a corresponding attachment. At the same time logs should contain info about screenshot capturing failure reason. |
|
Is this on the docs? Couldn't find any reference to screenshots there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #567