Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): Add Angular menu option and install SDK #765

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jan 21, 2025

Supersedes #741 - Part 1

Targeted to the epic branch.

Adds Angular menu option with SDK installation

Tested locally on Angular 17/19 - and unsupported Angular version

#skip-changelog

Copy link

github-actions bot commented Jan 21, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 266865a

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

andreiborza and others added 2 commits January 22, 2025 12:02
…o look for (#766)

status code 0 instead of arbitrary stdout strings

Recently, Nuxt started using `consola` which seems to not pipe output back to
stdout which in turn made our e2e tests fail.

Rather that checking arbitrary strings frameworks output at the end of their
build commands, we switch to checking that the build process exited with status
code 0.
@andreiborza andreiborza force-pushed the onur/angular-wizard-menu-option branch from 5c56a4d to 266865a Compare January 22, 2025 11:03
@Lms24 Lms24 merged commit 8181920 into onur/angular-wizard-base Jan 22, 2025
15 checks passed
@Lms24 Lms24 deleted the onur/angular-wizard-menu-option branch January 22, 2025 12:41
onurtemizkan added a commit that referenced this pull request Jan 22, 2025
Adds Angular menu option with SDK installation

---------

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants