feat(angular): Add Sentry setup in main.ts
#768
+217
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lms24
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Just one concern where I think we can use an already existing helper function.
Generally, I'm seeing quite a few duplicated functions from Remix and other SDKs in this flow but for now I'm fine with the duplication. I'll create a tracking issue to dedupe and extract some helper function to tackle later.
src/angular/sdk-setup.ts
Outdated
| import chalk from 'chalk'; | ||
| import { updateAppEntryMod } from './codemods/main'; | ||
|
|
||
| export function hasSentryContent( |
There was a problem hiding this comment.
m: can we use the hasSentryContent function from ast-utils.ts instead of this one here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #741 - Part 2
Targeted to the epic branch.
main.tswith feature selectionLocally tested
#skip-changelog