Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): add extended whitespace support to AppDelegate detection; add tests for code-tools #785

Merged
merged 8 commits into from
Feb 10, 2025

Conversation

philprime
Copy link
Contributor

  • Adds tests for the code tools used to insert the setup snippet
  • Adds more support for white-spacing in AppDelegate method detection

@philprime philprime self-assigned this Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e48220d

@philprime philprime changed the title feat: add extended whitespace support to AppDelegate detection feat(apple): add extended whitespace support to AppDelegate detection Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.47%. Comparing base (932ba05) to head (e48220d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   47.97%   49.47%   +1.50%     
==========================================
  Files          52       52              
  Lines        3525     3527       +2     
  Branches      892      894       +2     
==========================================
+ Hits         1691     1745      +54     
+ Misses       1642     1596      -46     
+ Partials      192      186       -6     
Flag Coverage Δ
e2e-tests 85.29% <ø> (ø)
unit-tests 48.03% <100.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philprime philprime changed the title feat(apple): add extended whitespace support to AppDelegate detection feat(apple): add extended whitespace support to AppDelegate detection; add tests for code-tools Feb 10, 2025
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extensive test suite. I added some suggestions to cover a few more edge cases.

src/apple/code-tools.ts Show resolved Hide resolved
test/apple/code-tools.test.ts Outdated Show resolved Hide resolved
test/apple/code-tools.test.ts Show resolved Hide resolved
philprime and others added 2 commits February 10, 2025 16:25
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit e16056a into master Feb 10, 2025
21 checks passed
@philprime philprime deleted the philprime/apple-wizard-tests branch February 10, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants