-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple): add extended whitespace support to AppDelegate detection; add tests for code-tools #785
Conversation
philprime
commented
Feb 7, 2025
- Adds tests for the code tools used to insert the setup snippet
- Adds more support for white-spacing in AppDelegate method detection
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 47.97% 49.47% +1.50%
==========================================
Files 52 52
Lines 3525 3527 +2
Branches 892 894 +2
==========================================
+ Hits 1691 1745 +54
+ Misses 1642 1596 -46
+ Partials 192 186 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extensive test suite. I added some suggestions to cover a few more edge cases.
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM