Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(apple): add unit tests for Fastfile injection #786

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

philprime
Copy link
Contributor

  • Adds unit tests to inject sentry cli into Fastfile
  • Changed the import of @clack/prompts to fix mocking

@philprime philprime self-assigned this Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (b82807c) to head (2955173).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   46.06%   47.97%   +1.90%     
==========================================
  Files          52       52              
  Lines        3523     3525       +2     
  Branches      892      893       +1     
==========================================
+ Hits         1623     1691      +68     
+ Misses       1696     1642      -54     
+ Partials      204      192      -12     
Flag Coverage Δ
e2e-tests 85.29% <ø> (ø)
unit-tests 46.47% <100.00%> (+1.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with two minor comments. Thanks for adding all the tests.

test/apple/fastfile.test.ts Outdated Show resolved Hide resolved
test/apple/fastfile.test.ts Outdated Show resolved Hide resolved
@philprime philprime merged commit 932ba05 into master Feb 10, 2025
21 checks passed
@philprime philprime deleted the philprime/apple-fastlane-tests branch February 10, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants