-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters. #152
Conversation
…/sentry-xamarin into feat/xamarin-privacy-info
…try/sentry-xamarin into feat/xamarin-privacy-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (although I'm not a Xamarin expert). I just suggested some tweaks to the changeog.
|
||
- Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters ([#152](https://github.com/getsentry/sentry-xamarin/pull/152)) | ||
|
||
Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project. | |
Due to new Apple requirements, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the fields required by Sentry, if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file and warn during the build if the required keys are not when building an iOS project. |
- Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters ([#152](https://github.com/getsentry/sentry-xamarin/pull/152)) | ||
|
||
Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project. | ||
Below you can find a snippet of the minimum required privacy manifest required by Sentry Xamarin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below you can find a snippet of the minimum required privacy manifest required by Sentry Xamarin: | |
Below you can find a snippet of the minimum privacy manifest required by Sentry Xamarin: |
As a requirement by Apple
This PR Adds a PrivacyInfo manifest containing all the required parameters by the SDK if the user didn't provide a PrivacyInfo manifest, otherwise, it will warn the user if their PrivacyInfo manifest is missing any required parameter by the SDK.
Other changes:
Close #148