Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters. #152

Merged
merged 49 commits into from
May 1, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Apr 29, 2024

As a requirement by Apple

This PR Adds a PrivacyInfo manifest containing all the required parameters by the SDK if the user didn't provide a PrivacyInfo manifest, otherwise, it will warn the user if their PrivacyInfo manifest is missing any required parameter by the SDK.

Other changes:

  • By default, the buildTransitive task is automatically loaded from a nuget package, that's why I added to the directory .prop files from the samples to load this task, so it behaves similarly how the SDK would behave when loaded from a nuget package.

Close #148

@lucas-zimerman lucas-zimerman changed the title Feat/xamarin privacy info Fix: Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters. Apr 29, 2024
@lucas-zimerman lucas-zimerman changed the base branch from main to lucas-zimerman-patch-1 April 30, 2024 18:44
@lucas-zimerman lucas-zimerman marked this pull request as ready for review April 30, 2024 19:03
Base automatically changed from lucas-zimerman-patch-1 to main May 1, 2024 00:05
@bruno-garcia bruno-garcia merged commit d48cb0f into main May 1, 2024
6 checks passed
@bruno-garcia bruno-garcia deleted the feat/xamarin-privacy-info branch May 1, 2024 00:07
Copy link

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although I'm not a Xamarin expert). I just suggested some tweaks to the changeog.


- Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters ([#152](https://github.com/getsentry/sentry-xamarin/pull/152))

Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project.
Due to new Apple requirements, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the fields required by Sentry, if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file and warn during the build if the required keys are not when building an iOS project.

- Validate PrivacyInfo.xcprivacy and warn users of required missing privacy parameters ([#152](https://github.com/getsentry/sentry-xamarin/pull/152))

Due to a requirement by apple, all Projects will require a ([Privacy Manifest file](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files)). Sentry will automatically patch your project with the required fields by Sentry if no privacy manifest file is provided. Otherwise, it will validate your privacy manifest file for the required fields by Sentry and warn you during the build time if the required keys are present or not when building an iOS project.
Below you can find a snippet of the minimum required privacy manifest required by Sentry Xamarin:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Below you can find a snippet of the minimum required privacy manifest required by Sentry Xamarin:
Below you can find a snippet of the minimum privacy manifest required by Sentry Xamarin:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS ITMS-91053: Missing API declaration
3 participants