Skip to content

Commit

Permalink
Fix snuba_perf_issue test
Browse files Browse the repository at this point in the history
  • Loading branch information
aliu39 committed Sep 9, 2024
1 parent 0173912 commit 2c63a78
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions tests/sentry/issues/endpoints/test_organization_group_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
PerformanceNPlusOneGroupType,
PerformanceRenderBlockingAssetSpanGroupType,
PerformanceSlowDBQueryGroupType,
ProfileFileIOGroupType,
)
from sentry.models.activity import Activity
from sentry.models.apitoken import ApiToken
Expand Down Expand Up @@ -3148,10 +3149,11 @@ def test_snuba_perf_issue(self, mock_query: MagicMock) -> None:
self.login_as(user=self.user)
# give time for consumers to run and propogate changes to clickhouse
sleep(1)
response = self.get_success_response(
sort="new",
query="user.email:myemail@example.com",
)
with self.feature([ProfileFileIOGroupType.build_visible_feature_name()]):
response = self.get_success_response(
sort="new",
query="user.email:myemail@example.com",
)
assert len(response.data) == 2
assert {r["id"] for r in response.data} == {
str(perf_group_id),
Expand Down Expand Up @@ -3923,8 +3925,8 @@ def test_snuba_heavy_error_handled_boolean(self, _: MagicMock) -> None:
def run_feedback_filtered_by_default_test(self, use_group_snuba_dataset: bool):
with Feature(
{
"organizations:feedback-ingest": True,
"organizations:feedback-visible": True,
FeedbackGroup.build_visible_feature_name(): True,
FeedbackGroup.build_ingest_feature_name(): True,
"organizations:issue-search-snuba": use_group_snuba_dataset,
}
):
Expand Down Expand Up @@ -3957,8 +3959,8 @@ def test_feedback_filtered_by_default_use_snuba_search(self, _):
def run_feedback_category_filter_test(self, use_group_snuba_dataset: bool):
with Feature(
{
"organizations:feedback-ingest": True,
"organizations:feedback-visible": True,
FeedbackGroup.build_visible_feature_name(): True,
FeedbackGroup.build_ingest_feature_name(): True,
"organizations:issue-search-snuba": use_group_snuba_dataset,
}
):
Expand Down

0 comments on commit 2c63a78

Please sign in to comment.