wip - activity when feedback attachment is deleted

relates to #67707
getsentry · Apr 8, 2024 · 9ae80e7 · 9ae80e7
1 parent 830cdcd
commit 9ae80e7
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 1 deletion.
diff --git a/src/sentry/api/endpoints/event_attachment_details.py b/src/sentry/api/endpoints/event_attachment_details.py
@@ -13,8 +13,10 @@
 from sentry.auth.superuser import superuser_has_permission
 from sentry.auth.system import is_system_auth
 from sentry.constants import ATTACHMENTS_ROLE_DEFAULT
+from sentry.models.activity import Activity
 from sentry.models.eventattachment import EventAttachment
 from sentry.models.organizationmember import OrganizationMember
+from sentry.types.activity import ActivityType
 
 
 class EventAttachmentDetailsPermission(ProjectPermission):
@@ -129,4 +131,11 @@ def delete(self, request: Request, project, event_id, attachment_id) -> Response
             return self.respond({"detail": "Attachment not found"}, status=404)
 
         attachment.delete()
+        Activity.objects.create(
+            group=attachment.group,
+            project=project,
+            type=ActivityType.DELETED_ATTACHMENT.value,
+            user_id=request.user.id,
+            data={},
+        )
         return self.respond(status=204)
diff --git a/src/sentry/types/activity.py b/src/sentry/types/activity.py
@@ -31,6 +31,7 @@ class ActivityType(Enum):
     SET_ESCALATING = 25
 
     SET_PRIORITY = 26
+    DELETED_ATTACHMENT = 27
 
 
 # Warning: This must remain in this EXACT order.

diff --git a/static/app/types/group.tsx b/static/app/types/group.tsx
@@ -372,6 +372,7 @@ export enum GroupActivityType {
   AUTO_SET_ONGOING = 'auto_set_ongoing',
   SET_ESCALATING = 'set_escalating',
   SET_PRIORITY = 'set_priority',
+  DELETED_ATTACHMENT = 'deleted_attachment',
 }
 
 interface GroupActivityBase {
@@ -630,6 +631,11 @@ export interface GroupActivityCreateIssue extends GroupActivityBase {
   type: GroupActivityType.CREATE_ISSUE;
 }
 
+interface GroupActivityDeletedAttachment extends GroupActivityBase {
+  data: {};
+  type: GroupActivityType.DELETED_ATTACHMENT;
+}
+
 export type GroupActivity =
   | GroupActivityNote
   | GroupActivitySetResolved
@@ -657,7 +663,8 @@ export type GroupActivity =
   | GroupActivityCreateIssue
   | GroupActivityAutoSetOngoing
   | GroupActivitySetEscalating
-  | GroupActivitySetPriority;
+  | GroupActivitySetPriority
+  | GroupActivityDeletedAttachment;
 
 export type Activity = GroupActivity;
 

diff --git a/static/app/views/issueDetails/groupActivityItem.tsx b/static/app/views/issueDetails/groupActivityItem.tsx
@@ -597,6 +597,8 @@ function GroupActivityItem({
             );
         }
       }
+      case GroupActivityType.DELETED_ATTACHMENT:
+        return tct('[author] deleted an attachment', {author});
       default:
         return ''; // should never hit (?)
     }