fix(ui): Remove spread of key prop (#83345)

getsentry · Jan 13, 2025 · e221530 · e221530
1 parent 2ce7d85
commit e221530
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/static/app/components/compactSelect/composite.tsx b/static/app/components/compactSelect/composite.tsx
@@ -180,7 +180,7 @@ function Region<Value extends SelectKey>({
       label={label}
     >
       {(opt: SelectOption<Value>) => (
-        <Item key={opt.value} {...opt}>
+        <Item {...opt} key={opt.value}>
           {opt.label}
         </Item>
       )}

diff --git a/static/app/components/compactSelect/index.tsx b/static/app/components/compactSelect/index.tsx
@@ -148,7 +148,11 @@ function CompactSelect<Value extends SelectKey>({
             );
           }
 
-          return <Item {...item}>{item.label}</Item>;
+          return (
+            <Item {...item} key={item.key}>
+              {item.label}
+            </Item>
+          );
         }}
       </List>
 

diff --git a/static/app/components/draggableTabs/draggableTabList.tsx b/static/app/components/draggableTabs/draggableTabList.tsx
@@ -439,7 +439,7 @@ export function DraggableTabList({items, onAddView, ...props}: DraggableTabListP
       disabledKeys={disabledKeys}
       {...props}
     >
-      {item => <Item {...item} />}
+      {item => <Item {...item} key={item.key} />}
     </BaseDraggableTabList>
   );
 }

diff --git a/static/app/components/dropdownMenu/index.tsx b/static/app/components/dropdownMenu/index.tsx
@@ -246,7 +246,7 @@ function DropdownMenu({
             );
           }
           return (
-            <Item size={size} {...item}>
+            <Item size={size} {...item} key={item.key}>
               {item.label}
             </Item>
           );

diff --git a/static/app/components/tabs/tabList.tsx b/static/app/components/tabs/tabList.tsx
@@ -281,7 +281,7 @@ export function TabList({items, variant, ...props}: TabListProps) {
       variant={variant}
       {...props}
     >
-      {item => <Item {...item} />}
+      {item => <Item {...item} key={item.key} />}
     </BaseTabList>
   );
 }