Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback: Filter empty feedbacks from being created #64950

Closed
JoshFerge opened this issue Feb 9, 2024 · 0 comments · Fixed by #64954
Closed

feedback: Filter empty feedbacks from being created #64950

JoshFerge opened this issue Feb 9, 2024 · 0 comments · Fixed by #64954

Comments

@JoshFerge
Copy link
Member

right now it seems possible for feedbacks with no content to be created. in

sentry/src/sentry/feedback/usecases/create_feedback.py

Line 118 in 0503359

def should_filter_feedback(event, project_id, source: FeedbackCreationSource):

we should strip whitespace of the message and see if its empty, and if so go ahead and filter it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(feedback): filter out empty feedbacks getsentry/sentry
1 participant
@JoshFerge