Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(yarn): Upgrade to 1.13.0 and enforce version #11494

Closed
wants to merge 1 commit into from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 12, 2019

We can enforce consistent yarn version by checking in a yarn release into the repo and defining the yarn release to use in .yarnrc.

See https://yarnpkg.com/en/docs/cli/policies for more information

We can enforce consistent `yarn` version by checking in a yarn release into the repo and defining the yarn path in `.yarnrc`.
@billyvg billyvg added the WIP label Jan 14, 2019
@billyvg
Copy link
Member Author

billyvg commented Jan 14, 2019

@mattrobenolt thoughts on checking in yarn into the repo? It'll guarantee that the yarn version used across developers and build tools will be in sync.

@mattrobenolt
Copy link
Contributor

You don't want my opinions.

@billyvg
Copy link
Member Author

billyvg commented Jan 14, 2019

Closing this as it seems clunky having to vendor yarn - there's not been any significant features that we use where we would need to enforce a specific yarn version.

@billyvg billyvg closed this Jan 14, 2019
@billyvg billyvg deleted the build/yarn/upgrade-to-1.13.0-enforce-version branch January 14, 2019 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants