feat: Use new AM SDK API #19041
Merged
feat: Use new AM SDK API #19041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
commented
May 27, 2020
| span.finish(); | ||
| span.timestamp = start + sizeInKb / 1000; | ||
| transaction.finish(true); | ||
| span.finish(start + sizeInKb / 1000); |
There was a problem hiding this comment.
@billyvg I made the changes to the file to use the new API.
But this line here in terms of calculating the endTimestamp for the Span seems very odd.
Time + Filesize? What is the reason behind this?
I suppose you are abusing the Span chart to visualize file size?
HazAT
commented
May 27, 2020
Comment on lines
+89
to
+92
| }); | ||
|
|
||
| Sentry.addGlobalEventProcessor(async event => { | ||
| return normalizeTransactionName(appRoutes, event); |
There was a problem hiding this comment.
@dashed Transaction still goes through event processors and this is the internal workaround for it.
EventProcessors are considered internal. And they work the same as beforeSend :)
dashed
approved these changes
May 27, 2020
|
@dashed Are the percy diffs flakey as always wrt to the performance page? |
|
@HazAT ah that might be something we'll have to address. 👍 I approved the Percy snapshots. |
|
Will merge this tomorrow morning |
billyvg
approved these changes
May 27, 2020
HazAT
added a commit
that referenced
this pull request
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the JS SDK to the new beta using the new AM API. getsentry/sentry-javascript#2600