-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code parts for CSP implementation for sentry and self-hosted #48699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution in style tags
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48699 +/- ##
==========================================
+ Coverage 80.33% 80.94% +0.60%
==========================================
Files 4780 4780
Lines 201867 202196 +329
Branches 11503 11503
==========================================
+ Hits 162174 163669 +1495
+ Misses 39438 38272 -1166
Partials 255 255
|
markstory
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt of #47980 and #48507 (which were reverted due to bugs).
This PR adds some preliminary code for adding a Content-Security-Policy-Report-Only header with minimal required permissions (at least I could not find any violations on sentry devserver and self-hosted).
The CSP middleware is disabled (commented in the MIDDLEWARE)
There is no report collecting enabled by default (CSP_REPORT_URI is not set), the intent is to customize it depending on the use case.