Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - feedback includes trace navigator #64672

Closed
wants to merge 1 commit into from

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Feb 6, 2024

Here's what the page looks like while this is loading, then when nothing is found.
There's also an earlier state where we don't know if we should even try to load the trace view (we need to look at the feedback itself to see if there's a trace id), in that case nothing is rendered at all, layout shift happens afterwards.

Loading
SCR-20240206-iqbn

Loaded, no trace found
SCR-20240206-ipzz

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 6, 2024
@ryan953 ryan953 closed this Feb 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant