Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): add project option for enabling crash/user report notifs #65352

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Feb 16, 2024

  • add new epoch, epoch 12
  • create new project option sentry:feedback_user_report_notification, and default it to True in epoch 12.
  • add to project model / serializer

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f27fa1) 83.34% compared to head (979acf1) 84.16%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #65352      +/-   ##
==========================================
+ Coverage   83.34%   84.16%   +0.81%     
==========================================
  Files        5266     5266              
  Lines      235483   235494      +11     
  Branches    40768    40769       +1     
==========================================
+ Hits       196271   198208    +1937     
+ Misses      38993    37067    -1926     
  Partials      219      219              
Files Coverage Δ
src/sentry/api/endpoints/project_details.py 88.11% <100.00%> (+0.04%) ⬆️
src/sentry/api/serializers/models/project.py 98.30% <ø> (ø)
src/sentry/models/options/project_option.py 100.00% <ø> (ø)
src/sentry/projectoptions/defaults.py 100.00% <100.00%> (ø)

... and 219 files with indirect coverage changes

@JoshFerge
Copy link
Member Author

context:

Plan for Alerting on feedbacks from old user report API / crash report embed form:

  • Right now we simply filter out "User Reports" (ones from crash report embed, and user report API), when we go to make notifications from feedbacks
  • There are too many orgs who use these in ways where it doesn't make sense for them to go into the default alert notification (e.g. they have it set up to answer true/false yes/no questions)
  • We'll make this a project setting, and have it on for new projects, and off for existing projects

@JoshFerge JoshFerge merged commit 7b70152 into master Feb 21, 2024
49 checks passed
@JoshFerge JoshFerge deleted the jferg/user-report-not-option branch February 21, 2024 18:50
snigdhas pushed a commit that referenced this pull request Feb 21, 2024
…ifs (#65352)

- [x] add new epoch, epoch 12
- [x] create new project option
`sentry:feedback_user_report_notification`, and default it to True in
epoch 12.
- [x] add to project model / serializer
JoshFerge added a commit that referenced this pull request Feb 23, 2024
…babled (#65561)

with project option created in
#65352, notify on user reports /
crash reports if they have the option enabled. See plan from PR comment:

#65352 (comment)
JoshFerge added a commit that referenced this pull request Feb 23, 2024
…otifications. (#65680)

Frontend counterpart to #65352,
used in #65561

---------

Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants