-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Add screenshots in feedback item #66530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Mar 7, 2024
billyvg
reviewed
Mar 7, 2024
static/app/components/feedback/feedbackItem/screenshotSection.tsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Mar 7, 2024
static/app/components/feedback/feedbackItem/screenshotSection.tsx
Outdated
Show resolved
Hide resolved
ryan953
reviewed
Mar 7, 2024
static/app/components/feedback/feedbackItem/screenshotSection.tsx
Outdated
Show resolved
Hide resolved
static/app/components/feedback/feedbackItem/screenshotSection.tsx
Outdated
Show resolved
Hide resolved
ryan953
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit picks, but looks good!
michellewzhang
approved these changes
Mar 7, 2024
static/app/components/feedback/feedbackItem/screenshotSection.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to view screenshot attachments in feedbacks. The screenshot preview and modal is the same as in issues, and the code is copied over from EventTagsAndScreenshots. This will be modified when user feedback is revamped.
Screenshot in feedback item:
Clicking on view screenshot:
Relates to: #63749