Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - activity when feedback attachment is deleted #68468

Closed
wants to merge 9 commits into from

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 8, 2024

relates to #67707

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Apr 8, 2024

Bundle Report

Changes will decrease total bundle size by 246 bytes ⬇️

Bundle name Size Change
sentry-webpack-bundle-array-push 26.17MB 246 bytes ⬇️

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.82%. Comparing base (30a576c) to head (7c126ad).

❗ Current head 7c126ad differs from pull request most recent head 46de2ab. Consider uploading reports for the commit 46de2ab to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #68468       +/-   ##
===========================================
+ Coverage   52.72%   79.82%   +27.09%     
===========================================
  Files        6473     6477        +4     
  Lines      287831   287929       +98     
  Branches    49611    49623       +12     
===========================================
+ Hits       151759   229832    +78073     
+ Misses     135513    57705    -77808     
+ Partials      559      392      -167     
Files Coverage Δ
...c/sentry/api/endpoints/event_attachment_details.py 84.72% <100.00%> (+49.00%) ⬆️
src/sentry/types/activity.py 100.00% <100.00%> (ø)
static/app/types/group.tsx 73.68% <ø> (ø)
...tatic/app/views/issueDetails/groupActivityItem.tsx 54.40% <0.00%> (-0.44%) ⬇️

... and 2886 files with indirect coverage changes

@aliu39
Copy link
Member

aliu39 commented Apr 29, 2024

Split up to #69878 and #69880

@aliu39 aliu39 closed this Apr 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
@aliu39 aliu39 deleted the ryan953/feedback-delete-attachment-activity branch September 3, 2024 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants