ref(insights): Use module URLs from constants for routing #71288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nesting is fine, but it's easier to use configured URL prefixes if they're unrolled.
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
May 21, 2024
Bundle ReportChanges will decrease total bundle size by 16.48kB ⬇️
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moving all the Starfish modules from
/performanceURLs to/insightsURLs. As part of this whole thing, I also want to clean up how the routes are generated. We define the base URLs for the modules in constants files, and the routes file should respect those! That way, everything is in sync.Flatten Insights URL structure
The nesting is fine, but it's easier to use configured URL prefixes if
they're unrolled. React Router supports slashes in routes, so the routing
works correctly.
Use module settings for routing