-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relay): add span-normalization.allowed-hosts into relay config #74195
Merged
jjbayer
merged 4 commits into
getsentry:master
from
aldy505:feat/relay-span-normalization-allowed-hosts
Aug 5, 2024
Merged
feat(relay): add span-normalization.allowed-hosts into relay config #74195
jjbayer
merged 4 commits into
getsentry:master
from
aldy505:feat/relay-span-normalization-allowed-hosts
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @jjbayer |
jjbayer
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to register the option, see for example
sentry/src/sentry/options/defaults.py
Lines 2347 to 2354 in 23ccc70
# list of platform names for which we allow using unsampled profiles for the purpose | |
# of improving profile (function) metrics | |
register( | |
"profiling.profile_metrics.unsampled_profiles.platforms", | |
type=Sequence, | |
default=[], | |
flags=FLAG_ALLOW_EMPTY | FLAG_AUTOMATOR_MODIFIABLE, | |
) |
jjbayer
approved these changes
Jul 29, 2024
Hey @jjbayer is there anything else that's blocking this PR? Since not all checks are green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Trigger: getsentry tests
Once code is reviewed: apply label to PR to trigger getsentry tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary relay config for getsentry/relay#3813, based on the discussion on getsentry/relay#3572
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.