Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relay): add span-normalization.allowed-hosts into relay config #74195

Merged
merged 4 commits into from
Aug 5, 2024
Merged

feat(relay): add span-normalization.allowed-hosts into relay config #74195

merged 4 commits into from
Aug 5, 2024

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Jul 12, 2024

Complementary relay config for getsentry/relay#3813, based on the discussion on getsentry/relay#3572

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505 aldy505 requested a review from a team as a code owner July 12, 2024 12:40
@aldy505
Copy link
Contributor Author

aldy505 commented Jul 12, 2024

/cc @jjbayer

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 12, 2024
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to register the option, see for example

# list of platform names for which we allow using unsampled profiles for the purpose
# of improving profile (function) metrics
register(
"profiling.profile_metrics.unsampled_profiles.platforms",
type=Sequence,
default=[],
flags=FLAG_ALLOW_EMPTY | FLAG_AUTOMATOR_MODIFIABLE,
)

@jjbayer jjbayer added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jul 24, 2024
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jul 27, 2024
@aldy505 aldy505 requested a review from jjbayer July 27, 2024 12:14
@jjbayer jjbayer added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jul 29, 2024
@jjbayer jjbayer enabled auto-merge (squash) August 2, 2024 06:21
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Aug 2, 2024
@aldy505
Copy link
Contributor Author

aldy505 commented Aug 4, 2024

Hey @jjbayer is there anything else that's blocking this PR? Since not all checks are green.

@shellmayr shellmayr added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Aug 5, 2024
@jjbayer jjbayer merged commit e28618c into getsentry:master Aug 5, 2024
47 of 49 checks passed
@aldy505 aldy505 deleted the feat/relay-span-normalization-allowed-hosts branch August 6, 2024 01:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants