ref: set relay fixture scope to module instead of session #77703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
test output definitely seems a lot quieter after this change |
jjbayer
approved these changes
Sep 19, 2024
Dav1dde
approved these changes
Sep 19, 2024
potentially a little if there are multiple relay test modules per suite -- but not by much if at all (and I'd bet that the loss there is dwarfed by the gain of wasted cpu handling the projectconfigs requests) |
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
this should be a reasonable balance between the current state (relay lasting for the whole session and causing flakiness) and function (setting up and tearing down the container continually) <!-- Describe your PR here. -->
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
this should be a reasonable balance between the current state (relay lasting for the whole session and causing flakiness) and function (setting up and tearing down the container continually) <!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should be a reasonable balance between the current state (relay lasting for the whole session and causing flakiness) and function (setting up and tearing down the container continually)