Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix type for serializers.models.rule #83444

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team January 14, 2025 21:58
@asottile-sentry asottile-sentry requested review from a team as code owners January 14, 2025 21:58
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/serializers/models/rule.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #83444       +/-   ##
===========================================
+ Coverage   51.67%   87.52%   +35.85%     
===========================================
  Files        9396     9406       +10     
  Lines      536705   537170      +465     
  Branches    21140    21140               
===========================================
+ Hits       277323   470179   +192856     
+ Misses     259031    66640   -192391     
  Partials      351      351               

@asottile-sentry asottile-sentry merged commit 75866a5 into master Jan 15, 2025
49 of 50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-types-serializers-rule branch January 15, 2025 15:01
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants