fix(eap-api): Sentry can receive val_double in addition to val_float
#83566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83566 +/- ##
==========================================
+ Coverage 87.55% 87.66% +0.10%
==========================================
Files 9409 9492 +83
Lines 537866 538830 +964
Branches 21179 21179
==========================================
+ Hits 470916 472346 +1430
+ Misses 66602 66136 -466
Partials 348 348 |
xurui-c
force-pushed
the
rachel/sentrydoubles
branch
from
4e9cf98 to
43a5735
Compare
xurui-c
force-pushed
the
rachel/sentrydoubles
branch
from
43a5735 to
60e425d
Compare
xurui-c
force-pushed
the
rachel/sentrydoubles
branch
from
60e425d to
6fe0ca1
Compare
xurui-c
changed the title
xurui-c
force-pushed
the
rachel/sentrydoubles
branch
from
6fe0ca1 to
924ae82
Compare
xurui-c
changed the title
val_double in addition to val_float
xurui-c
changed the title
val_double in addition to val_floatval_double in addition to val_float
xurui-c
force-pushed
the
rachel/sentrydoubles
branch
from
924ae82 to
e1e0951
Compare
Zylphrex
approved these changes
Jan 16, 2025
phacops
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
fix(eap-api): Snuba receives and returns doubles, while still supporting floats
getsentry/snuba#6782
Merged
Closed
xurui-c
added a commit
that referenced
this pull request
Jan 17, 2025
Follow up on #83566 Even when Snuba sends back doubles, Sentry uses `TYPE_MAP` to resolve them into floats. This is unintended behavior. This PR makes it so that Sentry looks at Snuba's response to determine if the values are doubles, instead of looking at `TYPE_MAP` to determine that. Co-authored-by: Rachel Chen <rachelchen@PL6VFX9HP4.attlocal.net>
xurui-c
added a commit
to getsentry/snuba
that referenced
this pull request
Jan 22, 2025
…ing floats (#6782) Update plan: 1. Sentry can receive doubles and floats 2. Snuba can receive (from Sentry) and return (to Sentry) doubles and floats. In the case of aggregation, replace float with double. This is fine because Sentry handles the case of receiving doubles already 3. Sentry asks for doubles only This PR addresses step 2. Step 1's PR is here: getsentry/sentry#83566 For every test that involved floats, I added a corresponding test with doubles. It ensures backward compatibility by verifying that Snuba can handle both floats and doubles --------- Co-authored-by: Rachel Chen <rachelchen@PL6VFX9HP4.attlocal.net> Co-authored-by: Rachel Chen <rachelchen@PL6VFX9HP4.local>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…at` (#83566) Update plan: 1. Sentry can receive doubles and floats 2. Snuba can receive and return doubles and floats. In the case of aggregation, replace float with double. This is fine because Sentry handles the case of receiving doubles already 3. Sentry asks for doubles only --------- Co-authored-by: Rachel Chen <rachelchen@PL6VFX9HP4.attlocal.net>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Follow up on #83566 Even when Snuba sends back doubles, Sentry uses `TYPE_MAP` to resolve them into floats. This is unintended behavior. This PR makes it so that Sentry looks at Snuba's response to determine if the values are doubles, instead of looking at `TYPE_MAP` to determine that. Co-authored-by: Rachel Chen <rachelchen@PL6VFX9HP4.attlocal.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/getsentry/eap-planning/issues/147
Update plan:
This PR addresses step 1