Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eap-api): Sentry distinguishes floats and doubles #83629

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(eap-api): Sentry distinguishes floats and doubles #83629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions src/sentry/snuba/spans_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,7 @@
from sentry.api.event_search import SearchFilter, SearchKey, SearchValue
from sentry.exceptions import InvalidSearchQuery
from sentry.search.eap.columns import ResolvedColumn, ResolvedFunction
from sentry.search.eap.constants import (
BOOLEAN,
DOUBLE,
FLOAT,
INT,
MAX_ROLLUP_POINTS,
STRING,
VALID_GRANULARITIES,
)
from sentry.search.eap.constants import MAX_ROLLUP_POINTS, VALID_GRANULARITIES
from sentry.search.eap.spans import SearchResolver
from sentry.search.eap.types import CONFIDENCES, ConfidenceData, EAPResponse, SearchResolverConfig
from sentry.search.events.fields import get_function_alias, is_function
Expand Down Expand Up @@ -137,16 +129,7 @@ def run_table_query(

for index, result in enumerate(column_value.results):
result_value: str | int | float
if resolved_column.proto_type == STRING:
result_value = result.val_str
elif resolved_column.proto_type == INT:
result_value = result.val_int
elif resolved_column.proto_type == FLOAT:
result_value = result.val_float
elif resolved_column.proto_type == DOUBLE:
result_value = result.val_double
elif resolved_column.proto_type == BOOLEAN:
result_value = result.val_bool
result_value = getattr(result, str(result.WhichOneof("value")))
result_value = process_value(result_value)
final_data[index][attribute] = resolved_column.process_column(result_value)
if has_reliability:
Expand Down
Loading