Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eap): handle null attribute values #6837

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

davidtsuk
Copy link
Contributor

@davidtsuk davidtsuk commented Jan 29, 2025

@davidtsuk davidtsuk changed the title fix(eap): move aggregation conditions from processor to rpc layer fix(eap): handle null attribute values Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2842 1 2841 11
View the top 1 failed tests by shortest run time
tests.web.rpc.v1.test_endpoint_trace_item_table.test_endpoint_trace_item_table.TestTraceItemTable::test_sparse_aggregate
Stack Traces | 0.382s run time
Traceback (most recent call last):
  File ".../v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table.py", line 2283, in test_sparse_aggregate
    assert response.column_values == [
AssertionError: assert [attribute_name: "animal_type"\nresults {\n  val_str: "bird"\n}\nresults {\n  val_str: "chicken"\n}\nresults {\n  val_str: "dog"\n}\n, attribute_name: "sum(wing.count)"\nresults {\n  val_double: 20\n}\nresults {\n  val_double: 10\n}\nresults {\n  val_double: 0\n  is_null: true\n}\n, attribute_name: "sum(bark.db)"\nresults {\n  val_double: 0\n  is_null: true\n}\nresults {\n  val_double: 0\n  is_null: true\n}\nresults {\n  val_double: 200\n}\n] == [attribute_name: "animal_type"\nresults {\n  val_str: "bird"\n}\nresults {\n  val_str: "chicken"\n}\nresults {\n  val_str: "dog"\n}\n,\n attribute_name: "sum(wing.count)"\nresults {\n  val_double: 20\n}\nresults {\n  val_double: 10\n}\nresults {\n  val_double: 0\n}\n,\n attribute_name: "sum(bark.db)"\nresults {\n  val_double: 0\n}\nresults {\n  val_double: 0\n}\nresults {\n  val_double: 200\n}\n]
  At index 1 diff: attribute_name: "sum(wing.count)"\nresults {\n  val_double: 20\n}\nresults {\n  val_double: 10\n}\nresults {\n  val_double: 0\n  is_null: true\n}\n != attribute_name: "sum(wing.count)"\nresults {\n  val_double: 20\n}\nresults {\n  val_double: 10\n}\nresults {\n  val_double: 0\n}\n
  Full diff:
    [
     attribute_name: "animal_type"
    results {
      val_str: "bird"
    }
    results {
      val_str: "chicken"
    }
    results {
      val_str: "dog"
    }
  - ,
  -  attribute_name: "sum(wing.count)"
  + , attribute_name: "sum(wing.count)"
  ? +
    results {
      val_double: 20
    }
    results {
      val_double: 10
    }
    results {
      val_double: 0
  +   is_null: true
    }
  - ,
  -  attribute_name: "sum(bark.db)"
  + , attribute_name: "sum(bark.db)"
  ? +
    results {
      val_double: 0
  +   is_null: true
    }
    results {
      val_double: 0
  +   is_null: true
    }
    results {
      val_double: 200
    }
    ,
    ]

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@davidtsuk davidtsuk force-pushed the david/fix/handle-nulls branch from eb995ac to 40a1979 Compare January 31, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant