return 200 instead of 204 on stream endpoint #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 32.44% 32.44%
=======================================
Files 45 45
Lines 2090 2090
Branches 71 71
=======================================
Hits 678 678
Misses 1412 1412 ☔ View full report in Codecov by Sentry. |
Lms24
approved these changes
Dec 13, 2023
Lms24
reviewed
Dec 13, 2023
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, I can merge getsentry/sentry-dotnet#2961 as-is since it relies on all of Sentry's HTTP logic (including retry-after, etc).
Otherwise I'll need to customize it to deal with 200 or 204, which is fine but since I imagine this might hit other SDKs adding support, changing the status code here might be the simplest.