Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show something to account for empty strings #656

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jan 15, 2025

No description provided.

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:19pm

@dcramer dcramer requested a review from BYK January 15, 2025 23:16
@dcramer
Copy link
Member Author

dcramer commented Jan 15, 2025

Ive still yet to diagnose what events are failing to render, but its a better experience with some kind of placeholder.

image

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.43%. Comparing base (f7480e4) to head (5c7a3ec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/integrations/sentry/components/events/Event.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   31.43%   31.43%           
=======================================
  Files          92       92           
  Lines        5433     5433           
  Branches      100      100           
=======================================
  Hits         1708     1708           
  Misses       3725     3725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK merged commit cfa9cc9 into main Jan 16, 2025
16 of 17 checks passed
@BYK BYK deleted the fix/empty-strings branch January 16, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants