Add some basic runtime icons #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 31.31% 31.76% +0.45%
==========================================
Files 92 92
Lines 5439 5519 +80
Branches 100 100
==========================================
+ Hits 1703 1753 +50
- Misses 3736 3766 +30 ☔ View full report in Codecov by Sentry. |
BYK
approved these changes
Jan 23, 2025
packages/overlay/src/integrations/sentry/components/PlatformIcon.tsx
Outdated
Show resolved
Hide resolved
packages/overlay/src/integrations/sentry/components/PlatformIcon.tsx
Outdated
Show resolved
Hide resolved
BYK
pushed a commit
that referenced
this pull request
Jan 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/overlay@2.11.0 ### Minor Changes - Add more platform icons and some browser icons ([#670](#670)) ## @spotlightjs/astro@2.4.2 ### Patch Changes - Updated dependencies \[]: - @spotlightjs/spotlight@2.10.2 ## @spotlightjs/electron@1.4.2 ### Patch Changes - Updated dependencies \[[`83eaaa06231776c7bc245348636aca564268cad4`](83eaaa0)]: - @spotlightjs/overlay@2.11.0 ## @spotlightjs/spotlight@2.10.2 ### Patch Changes - Updated dependencies \[[`83eaaa06231776c7bc245348636aca564268cad4`](83eaaa0)]: - @spotlightjs/overlay@2.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's more work to do here, but currently I cannot simply load in PlatformIcon due to compatibility
getsentry/platformicons#191
At the very least this will help with things like Next.js to grok if its server/client.