feat: Support PortablePDB embedded sources #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 74.11% 70.28% -3.83%
==========================================
Files 75 75
Lines 11439 11439
==========================================
- Hits 8478 8040 -438
- Misses 2961 3399 +438 |
Swatinem
reviewed
Jan 30, 2023
| @@ -49,4 +49,8 @@ modules: | |||
| location: "http://localhost:<port>/symbols/bd/a18fd85d4a4eb893022d6bfad846b1.src.zip" | |||
| download: | |||
| status: notfound | |||
| - source: local | |||
| location: "http://localhost:<port>/symbols/demo.wasm/BDA18FD85D4A4EB893022D6BFAD846B10/demo.wasm" | |||
There was a problem hiding this comment.
I’m wondering why a completely unrelated filetype now has more candidates? 🤔
There was a problem hiding this comment.
yeah that was weird but my assumption is that it's related to symbolic update
There was a problem hiding this comment.
possible. trying yet another file name pattern does definitely not hurt, though I would still love to find out why this suddenly happens.
Swatinem
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from getsentry/symbolic#734 now that symbolic got released,
this enables source context support for users uploading Portable PDBs built with
<EmbedAllSources>true</EmbedAllSources>project property.