filter out system frames when ingesting functions into generic metrics #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
approved these changes
Apr 17, 2024
…ystem-frames-from-generic-metrics
viglia
deleted the
viglia/feat/exclude-system-frames-from-generic-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes aim at dropping system frames when ingesting function metrics into the generic metrics platform.
Currently this would break the front-end in a few places. The logic to cap the list of functions to at most
maxUniqueFunctionsPerProfilehas therefore been moved out of theextractFunctionsFromCallTreesfunction and into a new one so that we can keep ingesting all of the frames for the current (custom)functionsdataset, but we can start dropping them when ingesting into the generic metrics platform.Once the front-end changes will be in place we can move this logic back to
extractFunctionsFromCallTreesand simplify it even more.To be merged after #441