fix: reuse one http client across different requests #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always reuse an http client across different requests as they're thread-safe and meant to be reused for better performance (connection pooling). This will avoid creating a new one (and relative http transport) for each and every requests we make to send metrics. Not doing this might lead to temporary port exhaustion and degradation of perfomances.
…nt-across-metrics-requests
phacops
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always reuse an http client across different requests as they're thread-safe and meant to be reused for better performance (connection pooling).
This will avoid creating a new one (and relative http transport) for each and every requests we make to send metrics.
Not doing this might lead to temporary port exhaustion and degradation of perfomances.