Deal with various deprecations of dependencies #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
tidy-deprecations
branch
from
0f8148f to
3cba2f5
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
tidy-deprecations
branch
3 times, most recently
from
7c2a4ee to
1bd84c6
Compare
xref: https://github.com/googleapis/google-cloud-go/blob/e535dc7c1d986c2ad6db3e8f5f2974935ee9ecda/migration.md Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
This does the same, but with much less boilerplate. xref: https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/endpoints/#v2-endpointresolverv2--baseendpoint Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
tidy-deprecations
branch
from
1bd84c6 to
1e8e232
Compare
Replace with simple manual construction of upper boolean representation, as the (construction of the) `golang.org/x/text/cases` replacement is way too complex for this use case. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
tidy-deprecations
branch
from
1e8e232 to
92aa55f
Compare
|
@felixfontein the remainders are all covered by tests, and closely following the deprecation notices yielded by the packages themselves. |
felixfontein
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #1258