Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofix AWS KMS encryption context bug #445

Merged
merged 11 commits into from
Mar 21, 2019

Conversation

ajvb
Copy link
Contributor

@ajvb ajvb commented Mar 19, 2019

This will prompt the user to automatically fix the bug that was described here: #435

@ajvb ajvb requested a review from autrilla March 19, 2019 22:00
@ajvb ajvb changed the title [WIP] Autofix encryption context [WIP] Autofix AWS KMS encryption context bug Mar 19, 2019
cmd/sops/common/common.go Outdated Show resolved Hide resolved
@ajvb ajvb changed the title [WIP] Autofix AWS KMS encryption context bug Autofix AWS KMS encryption context bug Mar 19, 2019
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me, just some changes to make the code nicer and some possible UX improvements.

cmd/sops/common/common.go Outdated Show resolved Hide resolved
cmd/sops/common/common.go Outdated Show resolved Hide resolved
cmd/sops/common/common.go Show resolved Hide resolved
cmd/sops/common/common.go Show resolved Hide resolved
cmd/sops/common/common.go Outdated Show resolved Hide resolved
cmd/sops/common/common.go Outdated Show resolved Hide resolved
cmd/sops/common/common.go Outdated Show resolved Hide resolved
cmd/sops/common/common.go Show resolved Hide resolved
cmd/sops/common/common.go Outdated Show resolved Hide resolved
@ajvb ajvb requested a review from autrilla March 20, 2019 22:15
@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #445 into dev/fix-aws-kms-enc-ctx will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           dev/fix-aws-kms-enc-ctx     #445   +/-   ##
========================================================
  Coverage                    36.42%   36.42%           
========================================================
  Files                           20       20           
  Lines                         2715     2715           
========================================================
  Hits                           989      989           
  Misses                        1637     1637           
  Partials                        89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e48b1...0898a5c. Read the comment docs.

cmd/sops/common/common.go Outdated Show resolved Hide resolved
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@ajvb ajvb merged commit 23fb078 into dev/fix-aws-kms-enc-ctx Mar 21, 2019
@ajvb ajvb deleted the ajvb/kms-enc-ctx-migration branch March 21, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants