-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofix AWS KMS encryption context bug #445
Conversation
Code to do the migration is still rough and needs clean up and further testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good to me, just some changes to make the code nicer and some possible UX improvements.
Codecov Report
@@ Coverage Diff @@
## dev/fix-aws-kms-enc-ctx #445 +/- ##
========================================================
Coverage 36.42% 36.42%
========================================================
Files 20 20
Lines 2715 2715
========================================================
Hits 989 989
Misses 1637 1637
Partials 89 89 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
This will prompt the user to automatically fix the bug that was described here: #435