Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.1 (develop -> master) #478

Merged
merged 10 commits into from
Jun 11, 2019
Merged

3.3.1 (develop -> master) #478

merged 10 commits into from
Jun 11, 2019

Conversation

ajvb
Copy link
Contributor

@ajvb ajvb commented Jun 11, 2019

No description provided.

ajvb and others added 9 commits May 16, 2019 21:29
* Fixes integration tests in travis to not run on PR's (they will now
run on merges into `develop` and `master`)
* Change README.rst and CONTRIBUTING.md to reflect the use of `develop`
as the primary development branch
use golang 1.12 for building sops
Make sure the key fingerprint is longer than 16 characters before
slicing it.

Closes #463
pgp/keysource: Check size of key fingerprint
* Allow set "json value" to be a string.

Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461

* Add functional test for --set'ing strings
It's been around 9 months since our last vendor update. This is also
needed for some new features being worked on for sops workspace.

Additionally, this PR regenerates the kms mocks.
@ajvb ajvb requested a review from autrilla June 11, 2019 18:08
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing we don't actually review the diffs for these 😛

New release lgtm

@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

Merging #478 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   36.42%   36.38%   -0.05%     
==========================================
  Files          20       20              
  Lines        2715     2718       +3     
==========================================
  Hits          989      989              
- Misses       1637     1640       +3     
  Partials       89       89
Impacted Files Coverage Δ
pgp/keysource.go 32.43% <0%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300927c...d61906a. Read the comment docs.

@ajvb
Copy link
Contributor Author

ajvb commented Jun 11, 2019

@autrilla Hehe yeah, I'd say it's not needed, just getting sign-off that the release looks good.

@ajvb ajvb merged commit e9e1e87 into master Jun 11, 2019
ajvb added a commit that referenced this pull request Sep 11, 2019
* Changes to travis config and docs for using develop (#462)

* Fixes integration tests in travis to not run on PR's (they will now
run on merges into `develop` and `master`)
* Change README.rst and CONTRIBUTING.md to reflect the use of `develop`
as the primary development branch

* use golang 1.12 for building sops

* pgp/keysource: Check size of key fingerprint

Make sure the key fingerprint is longer than 16 characters before
slicing it.

Closes #463

* Allow set "json value" to be a string. (#468)

* Allow set "json value" to be a string.

Adds back support for string values in --set, while retaining support
for yaml multidoc that caused this bug.

Fixes #461

* Add functional test for --set'ing strings

* Vendoring update (#472)

It's been around 9 months since our last vendor update. This is also
needed for some new features being worked on for sops workspace.

Additionally, this PR regenerates the kms mocks.

* Remove duplicate sentence from readme (#475)

* 3.3.1 bump and release notes (#477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants