Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault kv version and mount names in publish config #513

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

ajvb
Copy link
Contributor

@ajvb ajvb commented Aug 30, 2019

Adds support for publishing to vault using KV v1 and a different mount name (or multiple).

Also further expands the "destination rule config" unit tests.

Supporting kv v1 and a different mount name came back to me from user testing of sops publish.

Adds support for publishing to vault using KV v1 and a different mount
name (or multiple).
@ajvb ajvb requested a review from autrilla August 30, 2019 19:33
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@e9b9f7a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #513   +/-   ##
==========================================
  Coverage           ?   36.46%           
==========================================
  Files              ?       20           
  Lines              ?     2863           
  Branches           ?        0           
==========================================
  Hits               ?     1044           
  Misses             ?     1725           
  Partials           ?       94
Impacted Files Coverage Δ
config/config.go 71.42% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b9f7a...f140d5b. Read the comment docs.

@ajvb ajvb merged commit ebf0705 into develop Aug 30, 2019
@ajvb ajvb deleted the vault-publishing-improvements branch August 30, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants