Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document updatekeys command #552

Merged
merged 1 commit into from
Oct 21, 2019
Merged

document updatekeys command #552

merged 1 commit into from
Oct 21, 2019

Conversation

davidovich
Copy link

@davidovich davidovich commented Oct 19, 2019 •
edited
Loading

Add note about mandatory keys rotation when using --add-* options.

Covers and Fixes #550

@codecov-io
Copy link

codecov-io commented Oct 19, 2019 •
edited
Loading

Codecov Report

Merging #552 into develop will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #552      +/-   ##
===========================================
- Coverage    36.46%   36.29%   -0.18%     
===========================================
  Files           20       20              
  Lines         2863     2863              
===========================================
- Hits          1044     1039       -5     
- Misses        1725     1729       +4     
- Partials        94       95       +1
Impacted Files Coverage Δ
stores/flatten.go 87.28% <0%> (-4.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5b7ae...5207171. Read the comment docs.

autrilla
autrilla approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@autrilla
Copy link
Contributor

Woops, @davidovich , we need you to make the PR merge to develop instead of master.

@davidovich davidovich changed the base branch from master to develop October 21, 2019 18:38
@davidovich
document updatekeys command
5207171 
Add note about mandatory keys rotation when using --add-* options.
@davidovich
Copy link
Author

rebased on develop.

@autrilla autrilla merged commit 9abdff7 into getsops:develop Oct 21, 2019
@davidovich davidovich deleted the document-updatekeys branch October 21, 2019 20:36
@davidovich davidovich mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autrilla autrilla autrilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidovich @codecov-io @autrilla