Match file path relative to config file's directory #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autrilla
suggested changes
Mar 3, 2021
|
Hey @autrilla, please tell me if it's ok now. |
autrilla
reviewed
Mar 7, 2021
|
Oh, can you make this merge against |
|
Rebased to develop! |
autrilla
suggested changes
Mar 8, 2021
config/config.go
Outdated
| @@ -65,6 +67,7 @@ func FindConfigFile(start string) (string, error) { | |||
| type configFile struct { | |||
| CreationRules []creationRule `yaml:"creation_rules"` | |||
| DestinationRules []destinationRule `yaml:"destination_rules"` | |||
| Path string | |||
There was a problem hiding this comment.
Sorry I missed this in the last review, but this struct is used to parse the .sops.yaml file, and I don't want this exposed in there. Can you move this out of the struct and just pass it in as a parameter to the functions?
There was a problem hiding this comment.
No problem. Tell me if it's ok now.
autrilla
approved these changes
Mar 10, 2021
|
@autrilla I just saw you reverted the merge. Was that because of the failing tests (I just saw that as well). Do you have anything against merging a new PR (with passing tests)? |
|
Yes, it was because of failing tests after merging. Nothing against merging
a new PR that merges with passing tests.
…On Fri, 9 Apr 2021 at 23:30, Paulo Lieuthier ***@***.***> wrote:
@autrilla <https://github.com/autrilla> I just saw you reverted the
merge. Was that because of the failing tests (I just saw that as well). Do
you have anything against merging a new PR (with passing tests)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#827 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARH4V2ZAVDMTDWXVJUHT4TTH5WXBANCNFSM4YRYLXAQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480.