This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Use window.location.origin to create InstalledApp url #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the code used http://${window.location.hostname} to build
the base URL for checking the status of an app. Now it uses
${window.location.origin}.
In my case, I have set up nginx as a reverse proxy in order to use TLS
encryption for my node. I am accessing Umbrel via https:// now. As a
result, the functionality to check the status of services was not
working due to the browser blocking mixed content requests.
|
I got this project running locally to test and this change is working as expected. |
lukechilds
reviewed
Sep 13, 2022
|
@b-ryan good catch and thanks for submitting a PR! Would you be able to just confirm my amendments still resolve your issue? If so this is good to merge! |
|
What you said makes sense, glad you caught that. This does indeed still resolve my issue, thanks! |
|
Awesome, thanks @b-ryan! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code used http://${window.location.hostname} to build
the base URL for checking the status of an app. Now it uses
${window.location.origin}.
In my case, I have set up nginx as a reverse proxy in order to use TLS
encryption for my node. I am accessing Umbrel via https:// now. As a
result, the functionality to check the status of services was not
working due to the browser blocking mixed content requests.
I have not actually tested this code, as I don't have a development environment set up for Umbrel. I'm hoping someone else can test or this is straightforward enough to include.