Added optional offset to tap action (#31)

* Added optional offset to tap action * Fixed missing comma * Bumped version to 1.1.1 * Fixed parameter type
getyourguide · Sep 12, 2023 · 036c418 · 036c418
1 parent 60af8ca
commit 036c418
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/uiTestGlaze/build.gradle b/uiTestGlaze/build.gradle
@@ -6,7 +6,7 @@ plugins {
 
 ext {
     PUBLISH_GROUP_ID = 'io.github.getyourguide'
-    PUBLISH_VERSION = '1.1.0'
+    PUBLISH_VERSION = '1.1.1'
     PUBLISH_ARTIFACT_ID = 'uitestglaze'
 }
 

diff --git a/uiTestGlaze/src/main/java/com/getyourguide/uitestglazesample/TapHelper.kt b/uiTestGlaze/src/main/java/com/getyourguide/uitestglazesample/TapHelper.kt
@@ -14,6 +14,8 @@ internal class TapHelper(
         optional: Boolean,
         retryCount: Int,
         longPress: Boolean,
+        offsetX: Int,
+        offsetY: Int,
         hierarchy: TreeNode,
         device: UiDevice,
     ) {
@@ -24,19 +26,21 @@ internal class TapHelper(
                 optional,
                 device,
             ) ?: return
-        tapOnTreeNode(foundUiElement, optional, retryCount, longPress, device)
+        tapOnTreeNode(foundUiElement, optional, retryCount, longPress, offsetX, offsetY, device)
     }
 
     private fun tapOnTreeNode(
         uiElement: UiElement,
         optional: Boolean,
         retryCount: Int,
         longPress: Boolean,
+        offsetX: Int,
+        offsetY: Int,
         device: UiDevice,
     ) {
         tap(
-            uiElement.x + (uiElement.width) / 2,
-            uiElement.y + (uiElement.height) / 2,
+            uiElement.x + (uiElement.width) / 2 + offsetX,
+            uiElement.y + (uiElement.height) / 2 + offsetY,
             optional,
             retryCount,
             longPress,

diff --git a/uiTestGlaze/src/main/java/com/getyourguide/uitestglazesample/UiTestGlaze.kt b/uiTestGlaze/src/main/java/com/getyourguide/uitestglazesample/UiTestGlaze.kt
@@ -93,6 +93,8 @@ data class UiTestGlaze(
         optional: Boolean = false,
         retryCount: Int = 3,
         longPress: Boolean = false,
+        offsetX: Int = 0,
+        offsetY: Int = 0,
     ) {
         val hierarchy =
             hierarchySettleHelper.waitTillHierarchySettles(
@@ -101,7 +103,7 @@ data class UiTestGlaze(
                 config.waitTillLoadingViewsGoneTimeout,
                 config.waitTillHierarchySettlesTimeout,
             )
-        tapHelper.tap(uiElementIdentifier, optional, retryCount, longPress, hierarchy, device)
+        tapHelper.tap(uiElementIdentifier, optional, retryCount, longPress, offsetX, offsetY, hierarchy, device)
     }
 
     /**