Fix groupless search

[paul-paliychuk]

🚀	This description was created by Ellipsis for commit e869a67

fix: correct groupless search handling and update version to 0.3.1

Summary:

Fix handling of NULL group_ids in search queries and update version to 0.3.1.

Key points:

• Fix handling of NULL group_ids in search_utils.py.
• Update edge_fulltext_search(), edge_similarity_search(), and node_fulltext_search() to handle NULL group_ids.
• Bump version in pyproject.toml from 0.3.0 to 0.3.1.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 2ea4832 in 12 seconds

More details

• Looked at 146 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. graphiti_core/search/search_utils.py:65

• Draft comment:
  The logic for handling group_ids has changed. Previously, group_ids defaulted to [None] if it was None, but now it checks if group_ids is NULL. This change might affect behavior when group_ids is None. Ensure this aligns with the intended functionality.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The PR modifies the logic for handling group_ids in several functions. The new logic checks if group_ids is NULL and then applies a condition. However, the previous logic defaulted group_ids to [None] if it was None. This change might affect the behavior when group_ids is None. The new logic assumes that if group_ids is NULL, it should match NULL group IDs, which is a different behavior from the previous logic that would match None group IDs. This change should be verified to ensure it aligns with the intended functionality.

2. graphiti_core/search/search_utils.py:187

• Draft comment:
  The logic for handling group_ids has changed. Previously, group_ids defaulted to [None] if it was None, but now it checks if group_ids is NULL. This change might affect behavior when group_ids is None. Ensure this aligns with the intended functionality. (Also applicable in other similar instances)
• Reason this comment was not posted:
  Confidence changes required: 80%
  The same logic change for group_ids is applied in multiple places. It's important to ensure that this change is consistent with the intended behavior across all these instances.

3. graphiti_core/search/search_utils.py:305

• Draft comment:
  The logic for handling group_ids has changed. Previously, group_ids defaulted to [None] if it was None, but now it checks if group_ids is NULL. This change might affect behavior when group_ids is None. Ensure this aligns with the intended functionality. (Also applicable in other similar instances)
• Reason this comment was not posted:
  Confidence changes required: 80%
  The same logic change for group_ids is applied in multiple places. It's important to ensure that this change is consistent with the intended behavior across all these instances.

Workflow ID: wflow_5cXzmTDNXyIlg3Np

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 7ab2876 in 14 seconds

More details

• Looked at 14 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. graphiti_core/search/search.py:64

• Draft comment:
  Use if not group_ids: instead of if len(group_ids) == 0: for better readability and performance.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The check for an empty list should be done using if not group_ids: instead of if len(group_ids) == 0: for better readability and performance.

Workflow ID: wflow_YdDreKLy7UvTtwHh

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

❌ Changes requested. Incremental review on 8b9fcd5 in 17 seconds

More details

• Looked at 14 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_N0ySalbnmLjg1tRW

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on a029de9 in 11 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. graphiti_core/search/search.py:65

• Draft comment:
  The condition if group_ids is not None and len(group_ids) == 0: can be simplified to if group_ids == []: to directly check if group_ids is an empty list.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The condition for checking if group_ids is empty is incorrect. It should check if group_ids is an empty list, not just non-None and empty.

Workflow ID: wflow_gUH6T0F2KbRuH61E

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 5c781ac in 10 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. graphiti_core/search/search.py:65

• Draft comment:
  The change to if not group_ids: is a more Pythonic way to check for empty lists or None values. This improves code readability and is correct.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The change from checking group_ids is not None and len(group_ids) == 0 to not group_ids is a more Pythonic way to check for empty lists or None values. This change is correct and improves code readability.

Workflow ID: wflow_RSeZiR1p3sTUzs1j

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on e869a67 in 19 seconds

More details

• Looked at 14 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. graphiti_core/search/search.py:65

• Draft comment:
  The change from if not group_ids: group_ids = None to group_ids = group_ids if group_ids else None is a minor refactor that doesn't improve readability or performance. Consider reverting to the original, more straightforward code.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The change made in the PR is a minor refactor and does not introduce any new functionality or fix any bugs. It simply changes the way group_ids is assigned when it is empty. The original code was already clear and concise, and the new code does not offer any significant improvement in readability or performance.

Workflow ID: wflow_W8j8alfspCKJ2K9p

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[danielchalef]

lgtm