-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update UUID generation and message handling #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6c2c55e in 21 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pyproject.toml:3
- Draft comment:
Ensure the version update to 0.3.3 is consistent with semantic versioning and reflects the changes made in this PR. - Reason this comment was not posted:
Confidence changes required:33%
The version update in pyproject.toml is consistent with the changes made in the PR.
Workflow ID: wflow_fwN2UywIAYQZ2STV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 28a81d7 in 1 minute and 25 seconds
More details
- Looked at
55
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. graphiti_core/edges.py:36
- Draft comment:
The change fromuuid4().hex
tostr(uuid4())
ensures the UUID is in the standard format with hyphens, which is more readable and commonly used. This change is also applied innodes.py
. - Reason this comment was not posted:
Confidence changes required:10%
The change fromuuid4().hex
tostr(uuid4())
is consistent across bothedges.py
andnodes.py
. This change is correct as it ensures the UUID is in the standard format with hyphens, which is more readable and commonly used.
2. graphiti_core/nodes.py:71
- Draft comment:
The change fromuuid4().hex
tostr(uuid4())
ensures the UUID is in the standard format with hyphens, which is more readable and commonly used. This change is also applied inedges.py
. - Reason this comment was not posted:
Confidence changes required:10%
The change fromuuid4().hex
tostr(uuid4())
is consistent across bothedges.py
andnodes.py
. This change is correct as it ensures the UUID is in the standard format with hyphens, which is more readable and commonly used.
3. server/graph_service/routers/ingest.py:58
- Draft comment:
The addition ofuuid=m.uuid
inadd_messages_task
ensures that the UUID from the message is used when adding an episode, which is important for correct tracking or referencing. - Reason this comment was not posted:
Confidence changes required:10%
Iningest.py
, theadd_messages_task
function now includes theuuid
parameter when callinggraphiti.add_episode
. This change ensures that the UUID from the message is used, which is likely necessary for tracking or referencing the episode correctly.
4. server/graph_service/routers/retrieve.py:33
- Draft comment:
The change to returnget_fact_result_from_edge(entity_edge)
ensures the edge data is processed into a more useful or expected format for the response. - Reason this comment was not posted:
Confidence changes required:10%
Inretrieve.py
, theget_entity_edge
function now processes the result usingget_fact_result_from_edge
. This change likely formats or processes the edge data into a more useful or expected format for the response.
Workflow ID: wflow_626zxL6oNrbK2jQk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
fix: update UUID generation and message handling
Summary:
Update UUID generation and refine message handling in
ingest.py
andretrieve.py
.Key points:
uuid4().hex
tostr(uuid4())
inEdge
andNode
classes.uuid
parameter toadd_episode
inadd_messages_task()
.get_entity_edge()
to returnget_fact_result_from_edge(entity_edge)
.Generated with ❤️ by ellipsis.dev