Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle JSONDecodeError in is_server_or_retry_error function #133

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

danielchalef
Copy link
Member

@danielchalef danielchalef commented Sep 20, 2024

Important

Add json.decoder.JSONDecodeError handling to is_server_or_retry_error in client.py for retry logic.

  • Error Handling:
    • Update is_server_or_retry_error in client.py to handle json.decoder.JSONDecodeError.
    • Ensures JSON decoding errors are treated as retryable errors.

This description was created by Ellipsis for 1d840bf. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1d840bf in 54 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. graphiti_core/llm_client/client.py:38
  • Draft comment:
    Consider adding a comment explaining why JSONDecodeError is considered a retryable error. This will help future developers understand the reasoning behind this decision.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds JSONDecodeError to the list of exceptions that trigger a retry. This is a logical decision if JSON decoding errors are expected to be transient and recoverable by retrying the request.
2. graphiti_core/llm_client/client.py:37
  • Draft comment:
    The function name is_server_or_retry_error could be more descriptive. Consider renaming it to something like is_retryable_error to better convey its purpose.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function name should be more descriptive to indicate its purpose clearly.

Workflow ID: wflow_2mYHx9sigH9iSGBx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@danielchalef danielchalef merged commit 6d065d3 into main Sep 20, 2024
6 checks passed
@danielchalef danielchalef deleted the fix/langgraph-notebook branch September 20, 2024 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants