Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix bug in dedupe_node_list function #137

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

danielchalef
Copy link
Member

@danielchalef danielchalef commented Sep 21, 2024

The code changes fix a bug in the dedupe_node_list function where a node instance was not found in the node map. The bug is now handled by logging a warning message and skipping the iteration. This ensures that the function continues to execute without any errors.


Important

Fixes bug in dedupe_node_list by handling missing node instances with a warning and skipping iteration.

  • Bug Fix:
    • In dedupe_node_list function, handle missing node instances in node_map by logging a warning and skipping the iteration.
    • Ensures function execution continues without errors when a node is not found.

This description was created by Ellipsis for 1544425. It will automatically update as commits are pushed.

The code changes fix a bug in the `dedupe_node_list` function where a node instance was not found in the node map. The bug is now handled by logging a warning message and skipping the iteration. This ensures that the function continues to execute without any errors.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 1544425 in 15 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. graphiti_core/utils/maintenance/node_operations.py:283
  • Draft comment:
    Use node_instance.uuid instead of node_map[node_data['uuids'][0]].uuid to avoid potential KeyError.
            uuid_value = node_instance.uuid
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. graphiti_core/utils/maintenance/node_operations.py:272
  • Draft comment:
    The context preparation logic for LLM is repeated in extract_message_nodes, extract_text_nodes, and extract_json_nodes. Consider refactoring this into a separate function to adhere to the DRY principle.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The code has repetitive logic for preparing context for LLM in multiple functions. This violates the DRY principle.

Workflow ID: wflow_7coLru3tURpmy06p


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@danielchalef danielchalef merged commit 32b5153 into main Sep 21, 2024
6 checks passed
@danielchalef danielchalef deleted the fix/dedup-key-error branch September 21, 2024 04:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants