Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search method to return EntityEdge objects #48

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

danielchalef
Copy link
Member

@danielchalef danielchalef commented Aug 26, 2024


For more details, open the Copilot Workspace session.


🚀 This description was created by Ellipsis for commit d15b597

Summary:

The search method in graphiti_core/graphiti.py is updated to return EntityEdge objects, and corresponding test cases in tests/test_graphiti_int.py are modified to handle these objects.

Key points:

  • Update graphiti_core/graphiti.py search method to return EntityEdge objects instead of strings.
  • Modify tests/test_graphiti_int.py to handle EntityEdge objects by extracting fact attribute for logging.
  • Ensure search method returns relevant EntityEdge objects for a given query.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d15b597 in 11 seconds

More details
  • Looked at 54 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. tests/test_graphiti_int.py:81
  • Draft comment:
    Consider renaming 'FACTS' to 'EDGES' in the format_context function to better reflect the data being logged.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the return type of the search method from a list of facts to a list of EntityEdge objects. The test cases have been updated accordingly to extract facts from the EntityEdge objects. However, the format_context function still uses the term 'FACTS', which might be misleading now that the function deals with edges.
2. tests/test_graphiti_int.py:81
  • Draft comment:
    Avoid logging sensitive data. Ensure that edge.fact does not contain sensitive information before logging.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The code in graphiti_core/graphiti.py and tests/test_graphiti_int.py is mostly compliant with the rules. However, there is a potential issue with logging sensitive data in the test file.

Workflow ID: wflow_tMpMno7BNEdfHv3B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@danielchalef danielchalef merged commit 7ca4f7f into main Aug 27, 2024
6 checks passed
@danielchalef danielchalef deleted the danielchalef/update-search-method branch August 27, 2024 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants