-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/add-intro-gif v2 #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchalef
temporarily deployed
to
development
August 27, 2024 17:52
— with
GitHub Actions
Inactive
danielchalef
temporarily deployed
to
development
August 27, 2024 17:52
— with
GitHub Actions
Inactive
danielchalef
temporarily deployed
to
development
August 27, 2024 17:52
— with
GitHub Actions
Inactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to ea6c703 in 6 seconds
More details
- Looked at
32
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. README.md:20
- Draft comment:
The</br>
tag is not valid HTML and should be removed. The<br />
tag is self-closing. - Reason this comment was not posted:
Confidence changes required:50%
The closing
tag is unnecessary and incorrect HTML syntax. It should be removed for proper HTML formatting.
Workflow ID: wflow_UzfxODCTmFwjNVrf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates
README.md
to center the title and badges, and replaces the GIF markdown with an HTMLimg
tag for better alignment and size control.Key points:
README.md
to center the project title and badges using HTMLdiv
andp
tags.img
tag for the intro GIF, allowing for size specification and centering.Generated with ❤️ by ellipsis.dev