Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add group id support to service #92

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 6, 2024

🚀 This description was created by Ellipsis for commit 107763c

Summary:

This PR adds group_id support to the add_episode and search functions in the graph_service, updating the version to 0.2.3.

Key points:

  • Updated pyproject.toml version to 0.2.3.
  • Added group_id parameter to add_episode in server/graph_service/routers/ingest.py.
  • Modified search and get_memory functions in server/graph_service/routers/retrieve.py to include group_ids parameter.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 107763c in 15 seconds

More details
  • Looked at 49 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. server/graph_service/routers/ingest.py:58
  • Draft comment:
    Consider adding validation for request.group_id to ensure it is provided and valid before using it in add_messages_task. This will prevent potential issues if the group_id is missing or invalid.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR introduces group_id support in multiple places, but there is no validation for the group_id. This could lead to potential issues if the group_id is not provided or is invalid.
2. server/graph_service/routers/retrieve.py:23
  • Draft comment:
    Consider adding validation for query.group_id to ensure it is provided and valid before using it in the search function. This will prevent potential issues if the group_id is missing or invalid.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR introduces group_id support in multiple places, but there is no validation for the group_id. This could lead to potential issues if the group_id is not provided or is invalid.
3. server/graph_service/routers/retrieve.py:41
  • Draft comment:
    Consider adding validation for request.group_id to ensure it is provided and valid before using it in the get_memory function. This will prevent potential issues if the group_id is missing or invalid.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR introduces group_id support in multiple places, but there is no validation for the group_id. This could lead to potential issues if the group_id is not provided or is invalid.

Workflow ID: wflow_mzOdmSaKhvMTXiV3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 39ad28d into main Sep 6, 2024
6 checks passed
@paul-paliychuk paul-paliychuk deleted the prepare-release branch September 6, 2024 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant