build: include metadata in Windows binary #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
force-pushed
the
next
branch
2 times, most recently
from
189c37d to
6238b36
Compare
|
Sorry, can you rebase? |
Sure. Rebased. |
Keats
requested changes
Jan 26, 2022
Keats
approved these changes
Feb 7, 2022
|
perfect thanks! |
Keats
pushed a commit
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one:
This is a prerequisite for anyone who wishes to take a stab at #1686.
By adding metadata to the resulting binary, it will fill Microsoft's requirements pretty nicely (also Zola binary will have an icon in the Explorer!)
To support cross-compiling from Unix systems, some of the dependencies are not gated to a specific OS platform.